[fix #546] add human language in workshop description#625
[fix #546] add human language in workshop description#625fmichonneau wants to merge 2 commits intocarpentries:gh-pagesfrom
Conversation
|
@carpentries/lesson-infrastructure-committee do you have any suggestion about this proposed fix? |
_config.yml
Outdated
| # https://github.com/carpentries/workshop-template#creating-extra-pages | ||
| title: "Workshop Title" | ||
|
|
||
| # If this variable is set to something else than `""`, the language in which the |
There was a problem hiding this comment.
## human_language: the language in which the workshop is taught.
# If set to anything other than "", a note about the language of the workshop is
# added to the workshop description.
index.md
Outdated
|
|
||
| {% unless site.human_language == "" %} | ||
| <p id="human-language"> | ||
| <strong>The course will be conducted in {{ site.human_language }}.</strong> For this course, we will expect our participants to have basic understanding of {{ site.human_language }}. We will have several helpers to assist you if you need some terms to be translated. |
There was a problem hiding this comment.
I'm not sure about We will have several helpers to assist you if you need some terms to be translated. Which terms do you mean?
There was a problem hiding this comment.
I think I copied this from @malvikasharan and I understood it as any word that could have been difficult to understand. How about replacing "terms" with "words"?
There was a problem hiding this comment.
How about replacing "terms" with "words"?
it is better though it does not add clarity... I guess I don't understand the purpose of this sentence. I'd say something like this:
Helpers will be available if you need assistance with ... understanding lesson material. (???)
I'd also wrap the body of the paragraph.
| <strong>The workshop will be conducted in {{ site.human_language }}.</strong> | ||
| For this course, we will expect our participants to have basic understanding | ||
| of {{ site.human_language }}. We will have several helpers to assist you if | ||
| you need assistance with understanding the lesson material. |
There was a problem hiding this comment.
I think the "with" in the last line does not need to be here.
I do still find this somewhat confusing. Is the idea that the helpers will be fluent in both the workshop language and another language to help with translation?
Maybe there should be two fields in config (I don't love this proposal, but thinking together is better than alone):
workshop-human-language and local-human-language and then display the paragraph if those do not match (with appropriate update to the comment)? and in the reference to helpers can note that the helpers will be competent in both workshop and local languages? @malvikasharan @raynamharris would that be helpful?
There was a problem hiding this comment.
yes, I think that the intent was that helpers would be proficient both language and could help with translation if needed. That sentence I took from @malvikasharan's workshop might be too specific to be generalizable to all workshops, and it might be best to leave it out?
| # https://github.com/carpentries/workshop-template#creating-extra-pages | ||
| title: "Workshop Title" | ||
|
|
||
| ## human_language: the language in which the workshop is taught. |
There was a problem hiding this comment.
I suggest listing couple of examples after this first line, e.g. "English", "Dutch", etc.
@malvikasharan, @raynamharris, @rgaiacs what do you think of this implementation and text for #546.
TODO: