test(react): increase coverage for Slider#21837
test(react): increase coverage for Slider#21837adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21837 +/- ##
==========================================
+ Coverage 87.75% 94.86% +7.11%
==========================================
Files 536 537 +1
Lines 43637 45102 +1465
Branches 6696 7973 +1277
==========================================
+ Hits 38293 42787 +4494
+ Misses 5193 2171 -3022
+ Partials 151 144 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't plan to mark this pull request as ready for review until some of my earlier pull requests have been reviewed. I want to avoid diverting attention from them. Otherwise, these changes are ready to go. |
No issue.
Increased test coverage for
Sliderand deleted unreachable code.Changelog
Changed
Slider.Removed
Testing / Reviewing
yarn test --coverage \ --runTestsByPath packages/react/src/components/Slider/__tests__/Slider-test.js \ --collectCoverageFrom=packages/react/src/components/Slider/Slider.tsxPR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide