test(react): increase coverage for SassRenderer#21829
test(react): increase coverage for SassRenderer#21829adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21829 +/- ##
==========================================
+ Coverage 87.75% 94.80% +7.05%
==========================================
Files 536 537 +1
Lines 43637 45108 +1471
Branches 6725 7983 +1258
==========================================
+ Hits 38293 42766 +4473
+ Misses 5193 2198 -2995
+ Partials 151 144 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't plan to mark this pull request as ready for review until some of my earlier pull requests have been reviewed. I want to avoid diverting attention from them. Otherwise, these changes are ready to go. |
No issue.
Increased test coverage for
SassRendererand deleted unused code.Changelog
Changed
SassRenderer.Removed
Testing / Reviewing
I deleted unused code in the module. It came down to either removing it or adding tests for code that is no longer used.
There is one uncovered line in
convertValue. It is no longer exercised since theconvertproperty was removed. Since it serves as the fallback for the entire function, I left it in.yarn test --coverage \ --runTestsByPath packages/test-utils/src/__tests__/renderer-test.js \ --collectCoverageFrom=packages/test-utils/src/renderer.jsPR Checklist
As the author of this PR, before marking ready for review, confirm you:
Updated documentation and storybook examplesAddressed any impact on accessibility (a11y)Tested for cross-browser consistencyMore details can be found in the pull request guide