Skip to content

test(react): increase coverage for SassRenderer#21829

Open
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
adamalston:n/a-sass-renderer
Open

test(react): increase coverage for SassRenderer#21829
adamalston wants to merge 1 commit intocarbon-design-system:mainfrom
adamalston:n/a-sass-renderer

Conversation

@adamalston
Copy link
Contributor

No issue.

Increased test coverage for SassRenderer and deleted unused code.

Changelog

Changed

  • Increased test coverage for SassRenderer.

Removed

  • Deleted unused code.

Testing / Reviewing

I deleted unused code in the module. It came down to either removing it or adding tests for code that is no longer used.

There is one uncovered line in convertValue. It is no longer exercised since the convert property was removed. Since it serves as the fallback for the entire function, I left it in.

yarn test --coverage \
  --runTestsByPath packages/test-utils/src/__tests__/renderer-test.js \
  --collectCoverageFrom=packages/test-utils/src/renderer.js

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@netlify
Copy link

netlify bot commented Mar 15, 2026

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 3d8e6db
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/69b6410da79b8100085618b0
😎 Deploy Preview https://deploy-preview-21829--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 15, 2026

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3d8e6db
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/69b6410db9316b000854f590
😎 Deploy Preview https://deploy-preview-21829--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (b4297c5) to head (3d8e6db).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21829      +/-   ##
==========================================
+ Coverage   87.75%   94.80%   +7.05%     
==========================================
  Files         536      537       +1     
  Lines       43637    45108    +1471     
  Branches     6725     7983    +1258     
==========================================
+ Hits        38293    42766    +4473     
+ Misses       5193     2198    -2995     
+ Partials      151      144       -7     
Flag Coverage Δ
main-packages 87.82% <ø> (-0.13%) ⬇️
web-components 98.28% <ø> (+10.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston
Copy link
Contributor Author

I don't plan to mark this pull request as ready for review until some of my earlier pull requests have been reviewed. I want to avoid diverting attention from them. Otherwise, these changes are ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant