Skip to content
This repository was archived by the owner on Mar 8, 2023. It is now read-only.

docs(input): show password visibility knob only for password input#1029

Open
emyarod wants to merge 1 commit intocarbon-design-system:mainfrom
emyarod:docs/password-input-toggle-visibility-button-knob
Open

docs(input): show password visibility knob only for password input#1029
emyarod wants to merge 1 commit intocarbon-design-system:mainfrom
emyarod:docs/password-input-toggle-visibility-button-knob

Conversation

@emyarod
Copy link
Copy Markdown
Member

@emyarod emyarod commented Sep 13, 2022

Description

This PR updates the Input story so that the showPasswordVisibilityToggle knob is only visible when the input knob is set to "password"

Changelog

Changed

  • Input story knob helpers

@emyarod emyarod requested a review from a team as a code owner September 13, 2022 17:11
@emyarod emyarod requested review from RichKummer and ariellalgilmore and removed request for a team September 13, 2022 17:11
@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Sep 13, 2022

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1029/index.html

Built with commit: 4c095130d8b32188aaeb84df9f2bbdb42fe41880

@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Sep 13, 2022

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1029/index.html

Built with commit: 4c095130d8b32188aaeb84df9f2bbdb42fe41880

@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Sep 13, 2022

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1029/index.html

Built with commit: 4c095130d8b32188aaeb84df9f2bbdb42fe41880

@ibmdotcom-bot
Copy link
Copy Markdown
Contributor

ibmdotcom-bot commented Sep 13, 2022

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/1029/index.html

Built with commit: 4c095130d8b32188aaeb84df9f2bbdb42fe41880

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emyarod @ibmdotcom-bot