feat(link): add icon-placement option#1009
feat(link): add icon-placement option#1009emyarod wants to merge 4 commits intocarbon-design-system:mainfrom
icon-placement option#1009Conversation
emyarod
requested review from
RichKummer and
annawen1
and removed request for
a team
|
Deploy preview created for Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4 |
|
Deploy preview created for Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4 |
|
Deploy preview created for Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4 |
|
Deploy preview created for Built with commit: e7d8b6a047f44e6981a61f09516c023f1a99c2c4 |
ariellalgilmore
left a comment
ariellalgilmore
left a comment
There was a problem hiding this comment.
LGTM! If possible can we just move the iconPlacement knob to just the pairedWithIcon story
|
Agree with @ariellalgilmore on the knob update! I noticed that there seems to be some extra padding on the left when the icon is positioned on the left: Positioned right Positioned left Not sure if this would cause downstream effects. Also Percy's picking up 72 differences, but it looks like these may just be new pages or Percy's creating this for the first time. Figured I would flag just in case: |
|
@ariellalgilmore @RichKummer the knob should be on the |
RichKummer
left a comment
RichKummer
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing @emyarod !
4 participants
Related Ticket(s)
carbon-design-system/carbon-for-ibm-dotcom#8836
Description
This PR adds support for
icon-placementin the link component to potentially deprecate thelink-with-icondotcom component