fix: sqlite generated key is named lastInsertRowid#1501
Open
johannes-vogel wants to merge 10 commits intomainfrom
Open
fix: sqlite generated key is named lastInsertRowid#1501johannes-vogel wants to merge 10 commits intomainfrom
johannes-vogel wants to merge 10 commits intomainfrom
Conversation
johannes-vogel
commented
Feb 12, 2026
johannes-vogel
requested review from
BobdenOs,
danjoa,
patricebender,
sjvans and
stewsk
as code owners
BobdenOs
reviewed
Feb 13, 2026
db-service/lib/InsertResults.js
Outdated
| @@ -71,7 +71,7 @@ module.exports = class InsertResult { | |||
| // If no generated keys in entries/rows/values we might have database-generated keys | |||
| const rows = this.results.slice(0, this.affectedRows) // only up to # of root entries | |||
Contributor
There was a problem hiding this comment.
this.results should always be of length 1, because of the json insert SQLite only executes a single operation. For this operation it will return the number of affected rows and the last row ID. There for the for loop needs to include an additional loop that walks from lastInsertRowid - affectedRows4 till lastInsertRowid.
BobdenOs
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.