feat(a2j): enable path expression inside filter#1361
Draft
patricebender wants to merge 26 commits intomainfrom
Draft
feat(a2j): enable path expression inside filter#1361patricebender wants to merge 26 commits intomainfrom
a2j): enable path expression inside filter#1361patricebender wants to merge 26 commits intomainfrom
Conversation
for join relevant paths within infix filters __always__ build a correlated subquery with the current join node and put the complete filter condition into the subqueries `where`. I tested quite some examples with this approach and they all seem to do the trick. This approach also works for trivial conditions like `where books[author.ID = 5]` for which we would not necessarily need to do this.
this is a preparation for #1361 and it also makes our lifes easier as the infix filter at this place is semantically equivalent to a regular `where` clause.
patricebender
added a commit
that referenced
this pull request
Oct 24, 2025
this is a preparation for #1361 and it also makes our lifes easier as the infix filter at this place is semantically equivalent to a regular `where` clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for join relevant paths within infix filters always build a correlated subquery with the current join node and put the complete filter condition into the subqueries
where.I tested quite some examples with this approach and they all seem to do the trick. This approach also works for trivial conditions like
where books[author.ID = 5]for which we would not necessarily need to do this.TODO: