fix: re-arm status_expires when entering disk erasing LP#2155614#390
Open
skyecas wants to merge 2 commits into
Open
fix: re-arm status_expires when entering disk erasing LP#2155614#390skyecas wants to merge 2 commits into
skyecas wants to merge 2 commits into
Conversation
Collaborator
|
Check where you would like a Mattermost message to be sent to when CI completes and this PR is merged
|
skyecas
changed the title
Contributor
|
The bug references 3.4 and the logic around the release operation has changed in 3.5. Did you manage to reproduce it in master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodes in disk_erasing were silently transitioning to failed because the prior lifecycle timeout had expired. the
_start_disk_erasing()function was not arming a fresh status expires from, the node timeout.Resolves LP#2155614