Skip to content

chore: add MAC address duplicates notification#388

Draft
skatsaounis wants to merge 1 commit into
canonical:3.7from
skatsaounis:lp-2137492-37-36
Draft

chore: add MAC address duplicates notification#388
skatsaounis wants to merge 1 commit into
canonical:3.7from
skatsaounis:lp-2137492-37-36

Conversation

@skatsaounis

Copy link
Copy Markdown
Contributor

Resolves LP:2137492

@maas-lander

Copy link
Copy Markdown
Collaborator

Check where you would like a Mattermost message to be sent to when CI completes and this PR is merged

  • Direct message
  • ~maas

@@ -0,0 +1,172 @@
# MD8 Duplicate MAC addresses

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's review this here, and I will move it to Discourse when we approve its final format

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs an update to redirects in this repo: https://github.com/canonical/canonical.com/blob/main/redirects.yaml#L2011

Comment thread src/maasserver/deprecations.py
bypass MAAS's uniqueness rules (duplicates on the same `node_config`, or the
same MAC on different machines):

```python

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to provide some Python as part of the deprecation doc rather than git track this Python to MAAS codebase? Should we add a utility script instead? If yes on which branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants