Skip to content

fix: handle Markdown indented code blocks in rule 17 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LarytheLord wants to merge 2 commits into
base: main
Choose a base branch
from
+142 −2
Open

fix: handle Markdown indented code blocks in rule 17 #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2df2ed9
fix: detect MD indented code blocks in rule 17
LarytheLord Feb 25, 2026
f23dd45
test: preserve trailing newline in md indented code fixtures
LarytheLord Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions styles/Canonical/017a-Suggest-code-over-25-lines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ nonword: true
tokens:
- '``` ?({(code-block|code|sourcecode)})?[^{}\n]*\n((:[^\n]+:[^\n]*\n)+\n?)?(?!```)[^:\n][^\n]*\n(\n|(?!```)[^:\n][^\n]*\n){25,}```'
- '::: ?({(code-block|code|sourcecode)})?[^{}\n]*\n((:[^\n]+:[^\n]*\n)+\n?)?(?!:::)[^:\n][^\n]*\n(\n|(?!:::)[^:\n][^\n]*\n){25,}:::'
- '(^|\n)( {4}[^\n]+\n(( {4}[^\n]+)?\n){24,} {4}[^\n]+\n)'
- '::\n\n(( {3}[^\n]+)?\n){25,} {3}[^\n]+\n'
- '\.\. (code-block|code|sourcecode)::( [^\n]+)?\n(( {3,12}:[^\n:]*:[^\n]*\n)*)?\n(( {3}[^\n]+)?\n){25,} {3}[^\n]+\n'
1 change: 1 addition & 0 deletions styles/Canonical/017b-Warn-code-over-35-lines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ nonword: true
tokens:
- '``` ?({(code-block|code|sourcecode)})?[^{}\n]*\n((:[^\n]+:[^\n]*\n)+\n?)?(?!```)[^:\n][^\n]*\n(\n|(?!```)[^:\n][^\n]*\n){35,}```'
- '::: ?({(code-block|code|sourcecode)})?[^{}\n]*\n((:[^\n]+:[^\n]*\n)+\n?){0.1}(?!:::)[^:\n][^\n]*\n(\n|(?!:::)[^:\n][^\n]*\n){35,}:::'
- '(^|\n)( {4}[^\n]+\n(( {4}[^\n]+)?\n){34,} {4}[^\n]+\n)'
- '::\n\n(( {3}[^\n]+)?\n){35,} {3}[^\n]+\n'
- '\.\. (code-block|code|sourcecode)::( [^\n]+)?\n(( {3,12}:[^\n:]*:[^\n]*\n)*)?\n(( {3}[^\n]+)?\n){35,} {3}[^\n]+\n'
142 changes: 140 additions & 2 deletions tests/data/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ rules:
Line 26
```

This text is outside the code block.
This text is outside the code block.
expect:
triggers:
- |- # |- because we don't want the newline at the end.
Expand Down Expand Up @@ -686,7 +686,7 @@ rules:
Line 26
```

This text is outside the code block.
This text is outside the code block.
expect:
triggers:
- |- # |- because we don't want the newline at the end.
Expand Down Expand Up @@ -719,6 +719,65 @@ rules:
Line 26
```
severity: suggestion
- id: long-code-suggestion-md-indented
filetypes: [md]
content: |2
Line 01 of 26
Line 02
Line 03
Line 04
Line 05
Line 06
Line 07
Line 08
Line 09
Line 10
Line 11
Line 12
Line 13
Line 14
Line 15
Line 16
Line 17
Line 18
Line 19
Line 20
Line 21
Line 22
Line 23
Line 24
Line 25
Line 26
expect:
triggers:
- |2
Line 01 of 26
Line 02
Line 03
Line 04
Line 05
Line 06
Line 07
Line 08
Line 09
Line 10
Line 11
Line 12
Line 13
Line 14
Line 15
Line 16
Line 17
Line 18
Line 19
Line 20
Line 21
Line 22
Line 23
Line 24
Line 25
Line 26
severity: suggestion
- id: long-code-suggestion-myst
filetypes: [md]
content: |
Expand Down Expand Up @@ -1403,6 +1462,85 @@ rules:
Line 36
```
severity: warning
- id: long-code-warning-md-indented
filetypes: [md]
content: |2
Line 01 of 36
Line 02
Line 03
Line 04
Line 05
Line 06
Line 07
Line 08
Line 09
Line 10
Line 11
Line 12
Line 13
Line 14
Line 15
Line 16
Line 17
Line 18
Line 19
Line 20
Line 21
Line 22
Line 23
Line 24
Line 25
Line 26
Line 27
Line 28
Line 29
Line 30
Line 31
Line 32
Line 33
Line 34
Line 35
Line 36
expect:
triggers:
- |2
Line 01 of 36
Line 02
Line 03
Line 04
Line 05
Line 06
Line 07
Line 08
Line 09
Line 10
Line 11
Line 12
Line 13
Line 14
Line 15
Line 16
Line 17
Line 18
Line 19
Line 20
Line 21
Line 22
Line 23
Line 24
Line 25
Line 26
Line 27
Line 28
Line 29
Line 30
Line 31
Line 32
Line 33
Line 34
Line 35
Line 36
severity: warning
- id: long-code-warning-myst
filetypes: [md]
content: |
Expand Down