feat(azure): report failure if missing customdata#6779
Draft
cadejacobson wants to merge 7 commits intocanonical:mainfrom
Draft
feat(azure): report failure if missing customdata#6779cadejacobson wants to merge 7 commits intocanonical:mainfrom
cadejacobson wants to merge 7 commits intocanonical:mainfrom
Conversation
When ovf-env.xml is present but does not contain custom data, yet IMDS indicates that custom data was provided to the VM (via hasCustomData), report a provisioning failure. This helps surface cases where custom data is silently lost during provisioning. The behavior is gated behind a new feature flag, EXPERIMENTAL_FAIL_ON_MISSING_CUSTOMDATA, which is disabled by default while undergoing scale testing. Once validated, it will be renamed and enabled for new distro releases. Changes: - Add EXPERIMENTAL_FAIL_ON_MISSING_CUSTOMDATA feature flag - Add _hascustomdata_from_imds() helper to query IMDS metadata - Report ReportableErrorImdsInvalidMetadata when custom data is expected but missing from OVF provisioning media
cadejacobson
changed the title
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.) |
github-actions
bot
added
the
stale-pr
github-actions
bot
removed
the
stale-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type