Skip to content

Upgrade to work with latest version of ink#10

Open
jescalan wants to merge 3 commits intocameronhunter:mainfrom
jescalan:master
Open

Upgrade to work with latest version of ink#10
jescalan wants to merge 3 commits intocameronhunter:mainfrom
jescalan:master

Conversation

@jescalan
Copy link
Copy Markdown

@jescalan jescalan commented Jan 9, 2024

This PR updates all dependencies and makes the package work with v4 of ink 🎉

Closes #9

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 9, 2024

⚠️ No Changeset found

Latest commit: 571647d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jescalan
Copy link
Copy Markdown
Author

jescalan commented Jan 9, 2024

Doesn't look like changeset has been initialized, or the .changeset folder has been gitignored. Happy to add one if it's added back but don't want to init changesets as part of this PR.

@h0x91b
Copy link
Copy Markdown

h0x91b commented Jan 22, 2024

Hi, do you plan to merge it, or some additional work required?

Copy link
Copy Markdown
Owner

@cameronhunter cameronhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @jescalan! I've left a few comments.

Comment thread package-lock.json Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Please delete this package-lock.json file.

The repo uses yarn not npm.

Comment thread package.json Outdated
"files": [
"./build"
],
"type": "module",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: I'm not ready to make this an ES module.

I'd prefer to leave this as a CommonJS module for the time being.

@cameronhunter
Copy link
Copy Markdown
Owner

Doesn't look like changeset has been initialized, or the .changeset folder has been gitignored. Happy to add one if it's added back but don't want to init changesets as part of this PR.

I've just initialized changesets on main

@foldsters
Copy link
Copy Markdown

Any updates on this PR? I'm looking forward to using this package with ink v4. Anything I can do to help?

@arzkar
Copy link
Copy Markdown

arzkar commented Aug 17, 2024

Any update regarding this PR?

@jescalan
Copy link
Copy Markdown
Author

Ok I took a stab at updating this one, sorry it's been a very long time. Lots of yarn lockfile changes

@jyviko
Copy link
Copy Markdown

jyviko commented Nov 12, 2025

Hi All, thanks for the contributions. Can make this an ESM module. With ink moving to ESM it makes sense

@jescalan
Copy link
Copy Markdown
Author

Ok, just updated all the dependencies here and converted back to es module 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken with latest ink version

6 participants