Upgrade to work with latest version of ink#10
Upgrade to work with latest version of ink#10jescalan wants to merge 3 commits intocameronhunter:mainfrom
Conversation
|
|
Doesn't look like changeset has been initialized, or the |
|
Hi, do you plan to merge it, or some additional work required? |
cameronhunter
left a comment
There was a problem hiding this comment.
Thanks for making these changes @jescalan! I've left a few comments.
There was a problem hiding this comment.
Issue: Please delete this package-lock.json file.
The repo uses yarn not npm.
| "files": [ | ||
| "./build" | ||
| ], | ||
| "type": "module", |
There was a problem hiding this comment.
Issue: I'm not ready to make this an ES module.
I'd prefer to leave this as a CommonJS module for the time being.
I've just initialized changesets on |
|
Any updates on this PR? I'm looking forward to using this package with ink v4. Anything I can do to help? |
|
Any update regarding this PR? |
|
Ok I took a stab at updating this one, sorry it's been a very long time. Lots of yarn lockfile changes |
|
Hi All, thanks for the contributions. Can make this an ESM module. With ink moving to ESM it makes sense |
|
Ok, just updated all the dependencies here and converted back to es module 😁 |
This PR updates all dependencies and makes the package work with v4 of ink 🎉
Closes #9