Prepare r1.3 Patch Release

[fernandopradocabrillo]

What type of PR is this?

Add one of the following kinds:

• correction
• enhancement/feature
• repository management
• tests

What this PR does / why we need it:

Preparations for r1.3 patch release containing:

1. Fix request body and set to required
2. Include new tests in test plan covering the scope behaviour

[hdamker]

Just to avoid misunderstandings: I haven't done a full review, for that I have created camaraproject/ReleaseManagement#333

[GillesInnov35]

Thanks Fernando

[tanjadegroot]

On fix on version in the test file.
on the format of the operationId names, I am checking if this can be part of a patch release or not. if not, then that should wait for the next release.

[tanjadegroot]

Suggested change

	Feature: CAMARA Know Your Customer Fill-in API, v0.4 - Operation KYC_Fill-in
	Feature: CAMARA Know Your Customer Fill-in API, v0.4.1 - Operation KYC_Fill-in

[tanjadegroot]

Per commonalities, the operationId should be in lowerCamelCase in this patch release, or else in the next initial release.

[fernandopradocabrillo]

I'll open an issue to fix it in teh next release. I think that it is a change that impacts too many things to go in a patch release.

[GillesInnov35]

@tanjadegroot , @fernandopradocabrillo , does an upddate of yaml file with an operationId in lowerCamelCase may be included in a major version as the 2 string values are different (for case sensitive language) ?
I'm not sure it could have impact on existing source code ...
Gilles

[fernandopradocabrillo]

@GillesInnov35 changing the operationId is not a breaking change, it is not necessary to increase the major version when we change it since it is not part of the API contract. The endpoint and the ver remains the same, the operationId is an external identifier.

It might require an adaptation if any operator is using a code generator, but from the API perspective I think we should not consider it for a major change. In addition we are still in versions v0.X for Fill-in and in CAMARA so no need to go for a major, we can include it in v0.5.

[GillesInnov35]

ok @fernandopradocabrillo , got it.

[tanjadegroot]

Per Commonalities section 5.7.2, the operationId is defined in lowerCamelCase: For example: kycFillIn
see https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Design-Guide.md#572-operations.

However I am not sure if you can change the operationId in a patch release. Checking with ohters.
Changing this also requires changing the same in the testfiles.

[tanjadegroot]

Also check if you can align to Commonalities latest release r3.4. (and update the API-readiness-checklist accordingly)

[hdamker]

One minor issue which I have just seen when testing some agent:

Location: [code/API_definitions/kyc-fill-in.yaml:21]
Current: /r1.2/documentation/API_documentation/assets/kyc-fill-in_flow.png
Expected: /r1.3/documentation/API_documentation/assets/kyc-fill-in_flow.png
Fix: Update image reference to current release tag

[hdamker]

To be consistent with the Readiness Checklist.

[hdamker]

LGTM - leaving the final verdict from Release Management perspective to @tanjadegroot

[fernandopradocabrillo]

Hi @tanjadegroot, take a look whenever you can, thanks!

[tanjadegroot]

All OK from ReleaseManagement

/LGTM

[fernandopradocabrillo]

Hi @GillesInnov35, @ToshiWakayama-KDDI please approve so we can generate the patch. Thanks!

[ToshiWakayama-KDDI]

Thank you, @fernandopradocabrillo , @tanjadegroot , @hdamker .