fix: remove conflicting 400.2 test case from .feature files#221
Open
mohdfarhanakram wants to merge 1 commit intocamaraproject:mainfrom
Open
fix: remove conflicting 400.2 test case from .feature files#221mohdfarhanakram wants to merge 1 commit intocamaraproject:mainfrom
mohdfarhanakram wants to merge 1 commit intocamaraproject:mainfrom
Conversation
bigludo7
approved these changes
Apr 20, 2026
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Good catch !
Thanks !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
Removes the
400.2_empty_request_bodytest case from both.featurefiles. This test conflicts with422.1_missing_phone_number— both send{}as the request body with the same token context but expect different responses (400 vs 422).Since
phoneNumberis the only field inCreateCallForwardingSignaland it is optional,{}is a schema-valid body. The correct error for a missing phone number that cannot be derived from the access token is422 MISSING_IDENTIFIER, not400 INVALID_ARGUMENT.Which issue(s) this PR fixes:
Fixes #218
Special notes for reviewers:
As suggested by @FabrizioMoggio in the issue discussion.
Changelog input
Additional documentation
N/A