Skip to content

fix issue with callback executing before scrolling has actually finished #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joxerTMD wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue with callback executing before scrolling has actually finished #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions src/jump.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,24 @@ const jumper = () => {
function done () {
// account for rAF time rounding inaccuracies
window.scrollTo(0, start + distance)

// if scrolling to an element, and accessibility is enabled
if (element && a11y) {
// add tabindex indicating programmatic focus
element.setAttribute('tabindex', '-1')

// focus the element
element.focus()
}

// if it exists, fire the callback
if (typeof callback === 'function') {
callback()
}

// reset time for next jump
timeStart = false
window.requestAnimationFrame(() => {
// if scrolling to an element, and accessibility is enabled
if (element && a11y) {
// add tabindex indicating programmatic focus
element.setAttribute('tabindex', '-1')

// focus the element
element.focus()
}

// if it exists, fire the callback
if (typeof callback === 'function') {
callback()
}

// reset time for next jump
timeStart = false
})
}

// API
Expand Down