Conversation
|
Using this version of Jump going forward until container support is merged into main. |
|
I would love to see this merged. One potential block is that
|
|
@callmecavs Are there any plans to merge this and support this feature? Looks like there's quite a bit of interest. |
|
Any reasons to hesitating about merging this PR? |
| break | ||
|
|
||
| case 'string': | ||
| container = document.querySelector(options.container) |
There was a problem hiding this comment.
Wouldn’t it be better to look up the container going from the target up instead of from the document down?
container = target.closest(options.container)It would exclude errors where the container selector would be a common class name instead of id. Also might be faster.
|
any updates? |
See #50