Open
Conversation
Author
|
btw, if anyone is interested in trying this PR... $ npm install jump.js-cancelable@1.1.2-alphavar jumper = require('jump.js-cancelable');
jumper.jump(...);
jumper.cancel(); |
Owner
|
@bretkikehara havent had time to look closely at the changes to the source, but do think this is the best approach - no event listeners, just giving the user a function to cancel the jump as they see fit. will take a look when I get the chance - thanks for the submission and taking the initiative on this one. |
Author
|
So after using this a bit more, I found that exposing the timeStart is crucial to knowing the appropriate instance to cancel a jump. |
|
@bretkikehara Thanks, very useful patch! Minor changes: I'd like to see this will not break existing API, or much better: because with custom container support, I think, will be possible to run a few jumps simultaneously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When jump is called expose the cancel handler to stop the animation.
Tries to solve #7 without external dependencies or extra event handlers