Add a translucent background behind the words#7
Open
nahall wants to merge 7 commits intocalebsurface:masterfrom
Open
Add a translucent background behind the words#7nahall wants to merge 7 commits intocalebsurface:masterfrom
nahall wants to merge 7 commits intocalebsurface:masterfrom
Conversation
The translucent background helps the words become more visible.
The previous code would not automatically reconnect to ProPresenter if ProPresenter closed its Stage Display socket for some reason. The network code has been rewritten to allow it to automatically reconnect when ProPresenter reestablishes its socket. Additionally the network code has been simplified by removing dependencies.
Hide div "cs" when empty, and other cosmetic changes made by us.
Empty slides would contain newline characters which would fill the div "cs" with multiple line breaks, and cause undesirable graphical behavior, adding an empty bar at the bottom of the screen.
Fix empty slides filling div with line breaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for writing ProPresenter-OBS, it is very helpful! I added this little translucent background behind the words to give them more contrast so they are more visible if what the words are over are busy. I don't know if you want to pull formatting changes into your repository but here it is if you are interested.