Claire mobile (design changes reflected in Claire fixes PR, so doesn't need to be merged)#59
Open
miha-bhaskaran wants to merge 14 commits intomainfrom
Open
Claire mobile (design changes reflected in Claire fixes PR, so doesn't need to be merged)#59miha-bhaskaran wants to merge 14 commits intomainfrom
miha-bhaskaran wants to merge 14 commits intomainfrom
Conversation
This reverts commit f6e1d69.
Collaborator
|
@miha-bhaskaran HIIII PAGE SO SEXY 💯
|
Collaborator
|
Collaborator
|
UPDATED DEZIN NOTES
Mobile View
THANK U QUEEN THIS PAGE IS E A T I N G G G G ✨ 🔛 🔝 |
sarahhpeng
changed the title
jxmoose
reviewed
May 14, 2024
| <div className=" pl-[0.75rem] pr-[9.87] pt-[0rem] font-lato text-xs text-shadow bg-[#F173731A] rounded-lg w-[8rem]"> | ||
|
|
||
| <div className=" pl-[0.75rem] pr-[9.87] pt-[0rem] font-lato text-xs rounded-lg "> | ||
| <span className='text-shadow bg-[#F173731A]'> |
Collaborator
There was a problem hiding this comment.
should use a text tag for this unless span is necessary for some reason idk lol
jxmoose
reviewed
May 14, 2024
| spotlightTours.map((tour, i) => { | ||
| // Fetch the color for this tour/exhibit; fallback to a default color if not found | ||
| console.log(tour); | ||
| const color = colorsMap[tour.id] || '#F17373'; // Fallback color |
Collaborator
There was a problem hiding this comment.
maybe give a name to this color idk
jxmoose
reviewed
May 14, 2024
|
|
||
| useEffect(() => { | ||
| /** | ||
| * |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ New in this PR ✨
One liner: what did you do? 🛠
resolved all the comments on the dev figma file for maps and also enabled conditional rendering for desktop vs mobile
Coverage 🙆♀️
use this section to break up your task into submodules and track progress, copy from Linear and mark what was completed
How can the reviewer test your code? Where is this sprint located in the codebase? 👩💻
go to siteMap and run!
REQUIRED: Link a short video demo of the feature you have added. 👩💻
https://www.loom.com/share/eb92607475f343cd9c2c1ac0122c3af6?sid=01cc7754-fdb6-4a31-8125-2c97d362219f
Any bugs you encountered or still having trouble with? 🐛
Resources 📔
REQUIREMENTS in this section: Link all relevant online resources and related PRs. Write down any new dependencies or packages and link to their documentation. If you ran into bugs, link any stack overflow or online resources that helped you unblock yourself
❗IF this sprint was marked as FRONTEND on linear, cc Claire Wang
REMEMBER: once PR is made, also request a PR review Sarah, CC'ing is NOT enough!
🏚 cc: @sarahhpeng @cluurie