Select language at welcome sets app language#107
Open
stephaniewong2 wants to merge 5 commits intomainfrom
Open
Select language at welcome sets app language#107stephaniewong2 wants to merge 5 commits intomainfrom
stephaniewong2 wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Select language modal at welcome screen sets the language for the app and updates/sets user object and document. switching language in settings successfully sets language for app and updates user object and document
Screenshots
How to review
select language, log in and sign up and confirm that screens (that have translation) are in the correct language
Next steps
fix modal in welcome screen to match figma
Relevant Links
Online sources
Related PRs
CC: @surajr10 @themiachou8