Open
Conversation
…m working on seting up the createApi slide for the project
…ntrollers. Fixed the warning message on the console regarding the nesting of the elements. fixed most of the typescript errors and wrnings for the code i wrote
…rative into greg/fixing-api-bugs
…cooperative into dev/main
…ooperative into andrei/shiftScheduleNew
…student-cooperative into dev/main
…ooperative into andrei/shiftScheduleNew
…ooperative into andrei/shiftScheduleNew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Revamped Shift Schedule using sortedTable and Entity / Redux syntax. Meant to standardize the Shift Schedules for Managers and Members.
[x] - Manager Side standardized & light testing
[x] - Member Side standardized, needs more testing
[] - modal tables standardized
[] - quick-shift button functional
[] - status field added to some shifts
Screenshots
[//
]: # "Required for frontend changes, otherwise optional but strongly recommended. Add screenshots of expected behavior - GIFs if you're feeling fancy!"
How to review
Focus on manager side for now. Use search bar on "steven ismid" and "test luvr" as those are correctly formatted. LMK if you find other users that work. This was tested for the EUC manager so a lot of the users aren't up-to-standard, this includes adding functionality for status field in future users.
Next steps
Needs more documentation, I'll write this out once the testing for the Member side is complete. I'd like to be able to work on the modal tables next (quick-shift button + row click). think a lot of the hiccups with this table have to do with entities so future modal tables should hopefully come out sooner. TLDR: Member-side table -> more docs -> modal tables -> status field integration
Relevant Links
Online sources
Related PRs
CC: @gregoriiaaa