Dhruva bhat/ami 36 [style] style watering session#23
Dhruva bhat/ami 36 [style] style watering session#23dhruva-bhat wants to merge 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bhavitaap
left a comment
bhavitaap
left a comment
There was a problem hiding this comment.
GREAT JOB FIRST SPRINT YAYYY
just some styling fixes and a couple things here and there but everything looks really good yay! try to finish by EOD Wednesday
| ImageURL: "/images/C_truck.png", | ||
| }, | ||
| "Type D": { | ||
| ImageURL: "/orange.jpg", |
There was a problem hiding this comment.
add the purple image for type D
|
|
||
| <BackLink href="/sessions">← Back to Sessions</BackLink> | ||
| <BackLink href="/sessions"> | ||
| {IconSvgs.BackArrow} |
There was a problem hiding this comment.
change back to the arrow character instead of the icon, the icon is causing errors
<BackLink href="/sessions">← Back to Sessions</BackLink>
| object-fit: contain; | ||
| width: 22%; | ||
| object-fit: cover; | ||
| border-radius: 0.75rem; |
There was a problem hiding this comment.
make left border radius sharp and the right radius rounded
https://stackoverflow.com/questions/16036486/how-to-set-border-radius-of-some-corner-only-with-css
|
|
||
| export const RouteGroup = styled.p` | ||
| color: ${COLORS.black}; | ||
| color: ${COLORS.adlr_property_gray}; |
There was a problem hiding this comment.
change color back to adlr_white SORRY
| router.push(`/sessions/${sessionId}/${route.id}`); | ||
| }; | ||
|
|
||
| type VolunteerTypes = "Type A" | "Type B" | "Type C" | "Type D" | "Type E"; |
There was a problem hiding this comment.
import the VolunteerType enum from types folder instead
| export const RouteGroup = styled.p` | ||
| color: ${COLORS.black}; | ||
| color: ${COLORS.adlr_property_gray}; | ||
| font-size: 1.26488rem; |
| width: 65%; | ||
| padding: 1.5rem 1.75rem; | ||
| gap: 1.49rem; | ||
| padding: 0.5rem 2rem; |
There was a problem hiding this comment.
padding: 1.5625rem 1.5625rem 2rem 1.5625rem;
| gap: 1.49rem; | ||
| padding: 0.5rem 2rem; | ||
| flex: 1; | ||
| gap: 0.5rem; |
There was a problem hiding this comment.
looks fine but if possible download as svg from figma instead of png and update
| <path | ||
| d="M12 4L4 12" | ||
| stroke="#707070" | ||
| stroke-width="1.33333" |
There was a problem hiding this comment.
change strokeWidth, strokeLinecap, strokeLinejoin, and clipPath to camelCase instead of snake-case for some reason it's causing DOM errors?
2 participants
👍 What's new in this PR
Updated watering session styling page:
Screenshots
👍 How to review
main files to check:
general tests:
👍 Next steps
👍 Relevant links
Online sources
https://refine.dev/blog/typescript-record-type/
CC: @bhavitaap