Today/Notification and Control Panel tests#1173
Today/Notification and Control Panel tests#1173JoeSSS wants to merge 5 commits intocalabash:developfrom
Conversation
| Then(/^I can see Control Panel page elements$/) do | ||
| if ipad? | ||
| puts "Test is not stable on iPad; skipping" | ||
| end |
There was a problem hiding this comment.
This will not skip the iPad; it will continue the test.
You cannot return from the do block, so you will have to wrap the whole step in if !ipad?.
Did I make that mistake too in my step?
There was a problem hiding this comment.
Yep, I just copy/pasted it..
There was a problem hiding this comment.
Should I look at it on other tests also and fix?
| device.agent.touch({marked: 'Continue'}) | ||
| wait_for_external_animations | ||
| end | ||
| wait_for(options_or_timeout=3) do |
There was a problem hiding this comment.
Can you replace these with wait_for calls with:
// Will probably need to be longer in CI
timeout = 5
message = "Timed out waiting for XXXXX view after #{timeout} seconds"
bridge_wait_for(message, {timeout: timeout}) do
end
If you are waiting for views with Core#query, use:
wait_for_view(< query >)
wait_for_no_views(< query >)
| Then(/^I can open Notifications tab in Today and Notifications page$/) do | ||
| if ipad? | ||
| puts "Test is not stable on iPad; skipping" | ||
| end |
There was a problem hiding this comment.
See comment below about branching on !ipad?
| fail("Expected to see 'No Notifications' element") | ||
| end | ||
| else | ||
| wait_for(options_or_timeout=3) do |
There was a problem hiding this comment.
The fail with DeviceAgent, correct?
…tion_center_tests
|
Done |
|
Sweet! This is going make add the requested feature much easier. |
|
|
3 participants
DeviceAgent should see Today/Notification and Control Panel elements. It is possible to run it on iOS9/iOS10 simulators, using DeviceAgent and instruments