Skip to content

[fix] fix chunks size being above ES max result window #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgourdin merged 1 commit into from
Jan 29, 2026
Merged

[fix] fix chunks size being above ES max result window #2108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions c2corg_api/search/advanced_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from c2corg_api.search.mapping_types import meta_param_keys
from c2corg_api.search.search_filters import build_query
from c2corg_api.views.document import ES_MAX_RESULT_WINDOW


def get_search_documents(url_params, meta_params, doc_type):
Expand Down Expand Up @@ -69,7 +70,6 @@ def get_all_filtered_docs(

# use elastic search to apply filters
# to documents of type ids
# do it by chunk of size 'limit'
for _, id_chunk in enumerate(chunk_ids(
ids,
), start=1):
Expand All @@ -86,10 +86,13 @@ def get_all_filtered_docs(


def chunk_ids(ids_set):
"""Yield successive chunks of IDs from a set/list."""
"""
Yield successive chunks of IDs from a set/list.
chunk size is ES_MAX_RESULT_WINDOW
"""
ids_list = list(ids_set)
for i in range(0, len(ids_list), len(ids_set)):
yield ids_list[i:i + len(ids_set)]
for i in range(0, len(ids_list), ES_MAX_RESULT_WINDOW):
yield ids_list[i:i + ES_MAX_RESULT_WINDOW]


def contains_search_params(url_params):
Expand Down
Loading