feat: Smart/Origin parcours 3 itinévert by lgourdin · Pull Request #2100 · c2corg/v6_api

lgourdin · 2025-12-10T15:05:07Z

No description provided.

…tia requests

(cherry picked from commit bc12f10)

…area

…hen saving (issue 1789)

… is not the same as the day in parameters

…nctions for Itinevert routes

…cess waypoint of the route

…6_api

…rogress

codacy-production · 2025-12-10T15:05:55Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -1.93%	✅ 33.73%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`4e6ea74`)	20396	18889	92.61%
Head commit (`5e462ec`)	21076 (+680)	19112 (+223)	90.68% (-1.93%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#2100)	750	253	33.73%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

Nayor

Hello !

Merci pour le travail !

Quelques petites remarques concernant quelques commentaire en français qui traînent, des noqa et codes HTTP incorrect

Ma plus grosse interrogation concerne la réplication des filtres elastics, destinés à évoluer pour faire des recherches améliorées. Comment cela sera-t-il compatible avec ce système ?

Est-ce possible de rajouter des tests ? ☺

c2corg_api/__init__.py

c2corg_api/views/navitia.py

…of filters in database

…strings

(cherry picked from commit 260c375)

(cherry picked from commit 3f2d576)

Nayor

Beau travail

Encore quelques petites améliorations à faire, code/paramètres inutilisés à nettoyer, constantes à extraire (URL, paramètres) dans un .ini
Est-ce possible d'expliquer dans le README quand lancer update_navitia_coverage ?

Pour info / rappel, j'ai fait une PR pour mettre les scripts dans un répertoire adhoc (pour qu'ils ne trainent pas à la racine), et diminuer l'outage, si vous pouvez valider ça serai vraiment bien pour la mise en production
#2102

update_navitia_coverage.sh

SMART-ORIGIN-README.md

c2corg_api/search/advanced_search.py

SMART-ORIGIN-README.md

Nayor · 2026-01-23T18:11:39Z

c2corg_api/search/advanced_search.py

+    params,
+    meta_params,
+    ids,
+    keep_order,


à quoi sert ce paramètres ; il n'est jamais false ?
À enlever, ou commenter pour expliquer

Nayor · 2026-01-23T18:12:59Z

c2corg_api/search/advanced_search.py

+    return filtered_doc_ids, total_hits
+
+
+def chunk_ids(ids_set, chunk_size=100):


idem, valeur en dur ; à mettre dans une constante
Il n'est jamais utilisé ? -> à enlever

c2corg_api/views/navitia.py

SMART-ORIGIN-README.md

…e archived

Nayor

OK pour moi, merci pour les corrections

lgourdin and others added 30 commits July 28, 2025 16:11

[CI] add CI pipeline as in github

b2d3301

[CI] Update CI after reverting deploy method in 752b2ea

24c84bb

[hotfix] add distincts scripts and change sqlalchemy events

0dd9ad6

[CI] source env for CI

905fa55

[fix] support updating TC when waypoint is modified and optimize navi…

b11143b

…tia requests

[scripts] make distinct navitia scripts executable

288e183

[GHCI] source env file before launching pytest

1d0480f

(cherry picked from commit bc12f10)

[chore] replace deprecated log.warn by log.warning

fbaf190

[fix] delete existing stopareas for waypoint if moved in an unserved …

b6caaa4

…area

[fix] formatting error in log string that was triggering 500 errors w…

6a88e18

…hen saving (issue 1789)

[chore] fix linting issues

3a540a1

[CI] run test script with set -e

8233f1d

[new feature] add reachable routes route

bb40e9e

[new feature] add reachable waypoints route

830581a

[new feature] add coverage table

ddb2f03

[new feature] add script to retrieve and insert coverages

bcb9a97

[fix] fixed a bug when trying to insert doc that is not a waypoint

e28025a

[new feature] added routes to get journey/isochrone reachable doc

94e05a3

[fix] add q=title filter in reachable doc routes

eb86874

[fix] make sure waypoints are not reachable if journeys departure day…

cfa6f73

… is not the same as the day in parameters

[refactor] organization + documentation : factorization and helper fu…

5f13610

…nctions for Itinevert routes

[fix] fix issue when filtering with several areas

479e003

[new feature] added route to get coverage for area / area in isochrone

2a1a847

[fix] fixed a bug where bbox applied to routes was not done on the ac…

2bd8db5

…cess waypoint of the route

Merge branch 'gp/dev'

72df94c

[lint] flake8 linting

4950c16

[CI] don't create dir if exists

8a55a1a

[CI] clean after test and debug comment

9054d05

Merge branch 'main' of https://git.smart-origin.com/SmartOrigin/c2c_v…

971fea1

…6_api

[fix] fix CI

c67b0b3

gerome.perrin added 3 commits December 10, 2025 15:48

[new feature] add job handling for journey queries to monitor their p…

499b96b

…rogress

[lint] fix linter -> func names in lower case

53ff11f

[fix] fix search doc missing for coverage

2f5d6cb

Merge branch 'master' into smart-origin/revue_parcours_3

c32e727

Nayor requested changes Dec 10, 2025

View reviewed changes

gerome.perrin and others added 12 commits January 13, 2026 09:38

[refactor] Use of Elastic Search filters in reachable routes instead …

ae0b7ab

…of filters in database

[fix] fix sort + when no results found

52e451e

[lint] fix flake8 linter

02f362d

[fix] fix too restrictive offset and limit for navitia reachable docs

3893e0f

[improve] return error id when 404 for navitia/journeys route

7b381cc

[clean] fix noqa, translate french comms to english, remove use of f …

7eec110

…strings

[doc] update SO README

00438cb

(cherry picked from commit 260c375)

[fix] fix codacy issues

123a739

[clean] remove unused route

d06f85d

[fix] fix update_navitia_coverage script for prod usage

d9bb042

Merge branch 'master' into smart-origin/revue_parcours_3

7d44a8d

[clean] fix unused variable

9fdaba5

(cherry picked from commit 3f2d576)

Nayor reviewed Jan 23, 2026

View reviewed changes

SMART-ORIGIN-README.md Show resolved Hide resolved

gerome.perrin added 6 commits January 26, 2026 15:10

[clean] remove useless parameters

1355038

[doc] add coverage doc

cf3bad9

[clean] remove useless class

414ed36

[refactor] use of BASE_URL constant for navitia api

49220df

[clean] remove archive coverage class as coverages are not meant to b…

b958616

…e archived

[doc] update S/O readme

5e462ec

Nayor self-requested a review January 28, 2026 08:26

Nayor approved these changes Jan 28, 2026

View reviewed changes

lgourdin merged commit 944218c into master Jan 28, 2026
12 checks passed

lgourdin deleted the smart-origin/revue_parcours_3 branch January 28, 2026 09:51

		return filtered_doc_ids, total_hits


		def chunk_ids(ids_set, chunk_size=100):

Uh oh!

Comments

Conversation

lgourdin commented Dec 10, 2025

Uh oh!

codacy-production bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Uh oh!

Nayor left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nayor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nayor Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Nayor Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nayor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codacy-production bot commented Dec 10, 2025 •

edited

Loading

Nayor left a comment •

edited

Loading