Fix: panic when building modulo_10 checksum for longer barcodes#44
Open
ronnybremer wants to merge 2 commits intobuntine:masterfrom
Open
Fix: panic when building modulo_10 checksum for longer barcodes#44ronnybremer wants to merge 2 commits intobuntine:masterfrom
ronnybremer wants to merge 2 commits intobuntine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the calculation of the modulo 10 checksum all even and odd values of the passed in barcode are added, eventually leading to an overflow when building the final checksum. By casting them to u16 this overflow condition is avoided.