Add support for configuring domains starting with a number via environment variables (by using _ prefix)#3414
Open
ppenguin wants to merge 2 commits intobunkerity:devfrom
Open
Add support for configuring domains starting with a number via environment variables (by using _ prefix)#3414ppenguin wants to merge 2 commits intobunkerity:devfrom
_ prefix)#3414ppenguin wants to merge 2 commits intobunkerity:devfrom
Conversation
To support domains starting with a number configured through env vars, we need to prefix them with _ and allow such variables to be handled for config generation. fix env var strip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1857
Allows prefixing environment variables with
_with the main purpose to allow (v)host/domain names starting with a number (e.g.1mthe1.org->_1mthe1.org_USE_LETS_ENCRYPT_WILDCARD="yes").The
_prefix has been removed from the exclude prefixes list, but the_prefix is stripped from the variable name(s) as early as possible, so all further logic handles the server names etc. unchanged, i.e. as1mthe1.orgin this example.Also adds
NOMAD_to the exluded prefixes list to make startup in nomad deployments less noisy.