Add publishing workflow #519
Conversation
(Building on #462, thanks @paul-sachs!) This adds a publish workflow, which is triggered by publishing a release on this repo (similar to how the various protovalidate repositories work). The workflow takes the release's version, creates both a VS Code Marketplace release and OpenVSX release. Completes #22.
| setup_only: true | ||
| - name: install-deps | ||
| run: make install | ||
| run: npm ci |
There was a problem hiding this comment.
seemed like we should use npm ci in CI, not npm install...
| git config user.name "${{ github.actor }}" | ||
| git config user.email "${{ github.actor }}@users.noreply.github.com" |
There was a problem hiding this comment.
I think we need this to do the git commit that will result below on vsce publish <version>, where the <version> comes from the release tag. (I'd like to try this in a pre-release, hence adding all of that duplicate machinery here.)
| - name: Push version commit | ||
| run: | | ||
| git push origin HEAD:${{ github.event.repository.default_branch }} |
There was a problem hiding this comment.
Likewise, I think after the action creates the commit, we should push the commit directly to HEAD (it'll just be bumping the "version" field in package.json to match the tag).
|
@doriable, @paul-sachs - I think the only real way to test this publishing out is landing this PR and trying some pre-releases, which should give us some confidence that the regular tagging workflow will work. I'd suggest we land this, tag a pre-release called |
stefanvanburen
requested review from
doriable and
paul-sachs
and removed request for
paul-sachs
|
🤞 this works the first time when we try it out, but may need follow-ups to fix issues we run into. |
(Building on #462, thanks @paul-sachs!)
This adds a publish workflow, which is triggered by publishing a release on this repo (similar to how the various protovalidate repositories work). The workflow takes the release's version, creates both a VS Code Marketplace release and OpenVSX release.
Completes #22.