Fix comment ignores not working for group fields#4370
Open
04cb wants to merge 1 commit intobufbuild:mainfrom
Open
Fix comment ignores not working for group fields#437004cb wants to merge 1 commit intobufbuild:mainfrom
04cb wants to merge 1 commit intobufbuild:mainfrom
Conversation
For proto2 group fields, comments in source get attributed to the synthetic message that holds the group's fields, not the group field itself. This caused buf:lint:ignore comments on group field declarations to not be respected for errors on fields within the group. This fix adds logic to detect when a source path points to a descriptor within a synthetic message created for a group field, and also checks the parent group field's source path for comment ignores. Fixes bufbuild#4187
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For proto2 group fields, comments in source get attributed to the synthetic message that holds the group's fields, not the group field itself. This caused buf:lint:ignore comments on group field declarations to not be respected for errors on fields within the group.
This fix adds logic to detect when a source path points to a descriptor within a synthetic message created for a group field, and also checks the parent group field's source path for comment ignores.
Fixes #4187