Add round-trip and save format tests by dsmiller95 · Pull Request #3 · buck-co/save-async

add first tests. only one of them works, because:

dsmiller95

committed

got 2nd test working, by forcing per-test unique keys

dsmiller95

committed

fix swallowing exceptions in the async to coroutine converter

dsmiller95

committed

fix hidden exception. the Awaitable WaitForSecondsAsync api is incompatible with running on different threads. instead relying on C# System.Threading.Tasks

dsmiller95

committed

add presumed best-case save file format tests, failing currently

dsmiller95

committed

fix the save file format tests to conform w/ current function w/o the unity json converters

dsmiller95

committed

DRY up the test cases

dsmiller95

committed

add test for Vector3 serialization. seems to work

dsmiller95

committed

add test to test the unity json converterrs

dsmiller95

committed

flesh out the test ASMDEF

dsmiller95

committed

add TODO and variant test around a failing, potential bugged, test

dsmiller95

committed

more docs, and cleanup

dsmiller95

committed

remove creation of a saveManager game object from the tests - not necessary, Singleton will auto-create

dsmiller95

committed

add documentation for SaveManager internal state

dsmiller95

committed

create conditionally-compiling test assembly to test integration with UnityConverters

dsmiller95

committed

more DRY - functional helper for round-trip testing

dsmiller95

committed

rename tests. add a new test to make evident the Vector3 save format when using unity converters

dsmiller95

committed

add comments indicating the thread context of ISaveable methods

dsmiller95

committed

pre-review touchup

dsmiller95

committed

use recommendation from unity to test Awaitable async functions. don't need a custom to-coroutine converter: https://docs.unity3d.com/6000.0/Documentation/Manual/AwaitSupport.html

dsmiller95

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add round-trip and save format tests#3

Add round-trip and save format tests#3
dsmiller95 wants to merge 20 commits intobuck-co:mainfrom
dsmiller95:main

Commits on Sep 2, 2024

add first tests. only one of them works, because:

got 2nd test working, by forcing per-test unique keys

fix swallowing exceptions in the async to coroutine converter

fix hidden exception. the Awaitable WaitForSecondsAsync api is incompatible with running on different threads. instead relying on C# System.Threading.Tasks

add presumed best-case save file format tests, failing currently

fix the save file format tests to conform w/ current function w/o the unity json converters

DRY up the test cases

add test for Vector3 serialization. seems to work

add test to test the unity json converterrs

flesh out the test ASMDEF

add TODO and variant test around a failing, potential bugged, test

more docs, and cleanup

remove creation of a saveManager game object from the tests - not necessary, Singleton will auto-create

add documentation for SaveManager internal state

create conditionally-compiling test assembly to test integration with UnityConverters

more DRY - functional helper for round-trip testing

rename tests. add a new test to make evident the Vector3 save format when using unity converters

add comments indicating the thread context of ISaveable methods

pre-review touchup

use recommendation from unity to test Awaitable async functions. don't need a custom to-coroutine converter: https://docs.unity3d.com/6000.0/Documentation/Manual/AwaitSupport.html