Open
Conversation
bschwind
approved these changes
Oct 19, 2025
Owner
bschwind
left a comment
bschwind
left a comment
There was a problem hiding this comment.
LGTM, thanks for this and sorry for the super long wait!
| pub fn transform(&self, transform: &DMat4) -> Self { | ||
| let t = crate::transform::gp_trsf(transform); | ||
| // NOTE: Setting the copy argument does not seem to have an effect. | ||
| let mut res = ffi::BRepBuilderAPI_Transform_ctor(&self.inner, &t, true); |
Owner
There was a problem hiding this comment.
Could you pull true into a named local variable?
Suggested change
| let mut res = ffi::BRepBuilderAPI_Transform_ctor(&self.inner, &t, true); | |
| let copy = true; | |
| let mut res = ffi::BRepBuilderAPI_Transform_ctor(&self.inner, &t, copy); |
Contributor
Author
There was a problem hiding this comment.
Will do! Sorry for taking so long. Very busy at work the past several weeks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gp_Trsf::SetValuestransformmodule, testsgp_trsf(&DMat4) -> gp_TrsfShape::transformDescription
I needed a way to define a
Shapeonce and then duplicate that geometry throughout a model space using transform matrices, similar to "blocks" from the CAD world or "instanced rendering" from the GPU programming world.This PR exposes OCC's implementation of this capability through the
BRepBuilderAPI_Transformclass. This requires using agp_Trsfinstance as the transform matrix. There didn't seem to be a convenient way to construct these from aglamtype, so I added thetransformmodule and a simple test to ensure the construction is correct.One caveat here (that is also noted in the comments) is that the
gp_Trsfconstructor:wcomponent of any columnSo, the values of the output can be different than the input based on the orthogonality of the input.