Feat: Safely convert mappings (dictionaries) to JSON serializable objects - #493
Merged
Conversation
mtcarlone
temporarily deployed
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Failure
mtcarlone
had a problem deploying
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Failure
mtcarlone
had a problem deploying
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Failure
mtcarlone
temporarily deployed
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Failure
mtcarlone
had a problem deploying
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Failure
mtcarlone
had a problem deploying
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Failure
mtcarlone
temporarily deployed
to
Approve Integration Tests
April 10, 2025 21:59 — with
GitHub Actions
Inactive
llifoawing
approved these changes
Jun 9, 2025
llifoawing
left a comment
Member
There was a problem hiding this comment.
LGTM! (as a side note, the microbatch model configs dont work in databricks but since we dont have an integration test for databricks can tackle that in another PR)
mtcarlone
had a problem deploying
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Failure
mtcarlone
temporarily deployed
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Failure
mtcarlone
temporarily deployed
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Failure
mtcarlone
temporarily deployed
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Failure
mtcarlone
had a problem deploying
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Failure
mtcarlone
had a problem deploying
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Failure
mtcarlone
had a problem deploying
to
Approve Integration Tests
June 19, 2025 19:02 — with
GitHub Actions
Failure
llifoawing
temporarily deployed
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Inactive
llifoawing
had a problem deploying
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Failure
llifoawing
had a problem deploying
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Failure
llifoawing
had a problem deploying
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Failure
llifoawing
had a problem deploying
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Failure
llifoawing
had a problem deploying
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Failure
llifoawing
had a problem deploying
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Failure
llifoawing
temporarily deployed
to
Approve Integration Tests
June 20, 2025 22:22 — with
GitHub Actions
Inactive
Contributor
Author
|
Damn this breaks Trino 🤦 will get a fix up for that ... |
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 18:28 — with
GitHub Actions
Error
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Failure
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
mtcarlone
had a problem deploying
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Failure
mtcarlone
temporarily deployed
to
Approve Integration Tests
July 11, 2025 19:01 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
There have been a few errors due to dbt's microbatch models. Namely, these models introduce
datetimeobjects to different context variables available to us. These changes are not explicitly documented, and have caused a number of failures for users of this package.In order to better safeguard ourselves against future versions, this PR introduces a set of macros that convert all values in a mapping (dictionary) object to something that is JSON serializable. Right now that is a
datetimeobject, but it can be updated easily to handle for more later on.This macro has been deployed to the two areas that were impacted by microbatch models and CLI arguments (
modelsandinvocations). The deployment pattern can be followed for other uploads.Update type - breaking / non-breaking
What does this solve?
This solves a number of issues caused by microbatch models. It should also future-proof us a bit ... hopefully.
Outstanding questions
What databases have you tested with?