feat(#84): add ability to optionally apply abs and negated functions inline#85
Closed
kylemilloy wants to merge 5 commits intobrick:masterfrom
Closed
feat(#84): add ability to optionally apply abs and negated functions inline#85kylemilloy wants to merge 5 commits intobrick:masterfrom
kylemilloy wants to merge 5 commits intobrick:masterfrom
Conversation
Member
|
Closing as per #84. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tickets resolves #84.
Added tests to cover off true/false and closures that return the same. The idea here is that you can optionally assign whether or not you want to make a value absolute or negated based on a logic gate inline. Compare the two code examples of how this is done:
What you would have to do before:
And what this allows you to do now:
or
Syntax is much more clear and succinct. My use case for this as outlined in #84 is to bring this into brick/money where we require this where we're manipulating values in an accounting system.