Add missing self import and replace deprecated method#410
Merged
kaleidawave merged 3 commits intobrendanzab:masterfrom Feb 28, 2026
Merged
Add missing self import and replace deprecated method#410kaleidawave merged 3 commits intobrendanzab:masterfrom
kaleidawave merged 3 commits intobrendanzab:masterfrom
Conversation
When setting up the readme example, I found that `term::emit` was deprecated and there was a missing import I went with `emit_to_write_style` since that was used in the example folder, but let me know if there is a better option!
20jasper
changed the title
Collaborator
|
Thanks, I had not realised it was wrong! I know there is a way to test those sort of examples in the |
Collaborator
|
Apologies that it has taken me a while to get round to this. Have added Thanks for spotting the initial issue and correcting the README! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up the readme example, I found that
term::emitwas deprecated and there was a missing importI went with
emit_to_write_stylesince that was used in the example folder, but let me know if there is a better option!