Skip to content

rewrite: update documentation with use-case #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibihim wants to merge 1 commit into
base: sig-auth-acceptance
Choose a base branch
from
Open

rewrite: update documentation with use-case #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/authorization/rewrite/attributes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
)

// AttributesGenerator is a an interface for generating a list of attributes.
// Attributes must be adjusted dependant on the configuration and context.
// Attributes must be adjusted dependent on the configuration and context.
type AttributesGenerator interface {
Generate(context.Context, authorizer.Attributes) []authorizer.Attributes
}
Expand Down Expand Up @@ -86,7 +86,10 @@ func (b *ResourceAttributesGenerator) Generate(ctx context.Context, attr authori
// and verifies its authorization against a predefined kubernetes resource
// template. The template is rewritting using client input data, which is VERY
// DANGEROUS. It should only be used in a narrow use-case, where the upstream
// is interpreting the input data as well.
// is interpreting the input data as well. It has the potential for vulnerabilities
// if the proxy and upstream interpret data differently, which is not uncommon.
//
// The known use-case is the prom-label-proxy (https://github.com/prometheus-community/prom-label-proxy).
type TemplatedResourceAttributesGenerator struct {
attributes *ResourceAttributes

Expand Down
Loading