Update openai provider types#326
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13f1efb98a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| #[derive(Debug, Clone, Default, Serialize, Deserialize)] | ||
| pub struct OpenAIReasoning { | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub context: Option<ReasoningContext>, |
There was a problem hiding this comment.
When a Responses request contains only reasoning.context (allowed by the updated schema because effort, summary, and generate_summary are all optional), this new field makes typed_params.reasoning present, and request_to_universal converts any present OpenAIReasoning into ReasoningConfig { enabled: Some(true), ... } even though context is not represented there. If that universal request is then emitted to Chat Completions, Anthropic, or Google, the provider conversion synthesizes a default reasoning effort/budget, changing a context-selection-only request into one that explicitly enables reasoning; only create canonical reasoning when an effort/summary field is present, or model context separately.
Useful? React with 👍 / 👎.
1 participant
Automated update of Lingua provider types.
Provider:
openaiFeedback: comment
/bt goodor/bt badto log review feedback to the Braintrust trace.Validation
./pipelines/generate-provider-types.sh openai: successmake generate-types: successmake generate-types: successcargo fmt --all: successcargo build --all-features: successcargo clippy --all-targets --all-features -- -D warnings: successmake typed-boundary-check: successcargo test -p coverage-report --test cross_provider_test cross_provider_transformations_have_no_unexpected_failures: successThis PR is created even when validation fails so the generated update and repair attempt are available for manual follow-up.