Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds the wkhtmltopdf dependency (and xvfb) to support HTML-to-PDF conversion in PHP images.
- Updated dependency lists in PHP 8.4, 8.3, 7.4, and 7.2 configuration files
- Introduces a comment section for command-line dependencies in each YAML file
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| php/8.4/bookworm.yaml | Added wkhtmltopdf and xvfb with an inline comment |
| php/8.3/bookworm.yaml | Added wkhtmltopdf and xvfb with an inline comment |
| php/7.4/bookworm.yaml | Added wkhtmltopdf and xvfb with an inline comment |
| php/7.2/bookworm.yaml | Added wkhtmltopdf and xvfb with an inline comment |
Files not reviewed (1)
- MODULE.bazel: Language not supported
dmeijboom
force-pushed
the
feat/setup-wkhtmltopdf
branch
6 times, most recently
from
d582f39 to
6b6840b
Compare
dmeijboom
force-pushed
the
feat/setup-wkhtmltopdf
branch
from
6b6840b to
8682875
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wkhtmltopdfis required to convert HTML to PDF.Changes:
wkhtmltopdfdependency