Open
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Aug 25, 2025
Comment on lines
109
to
+112
| return process.platform === `win32` | ||
| ? str.replace(/^.*zipfile:\//, ``) | ||
| : str.replace(/^.*zipfile:/, ``); | ||
| } break; | ||
|
|
||
| } |
Author
There was a problem hiding this comment.
this isn't part of check-spelling, but it is something I would encourage in my other lives... the break is unreachable because the return ends the code path.
Comment on lines
114
to
+118
| default: { | ||
| return process.platform === `win32` | ||
| ? str.replace(/^\^?(zip:|\/zip)\/+/, ``) | ||
| : str.replace(/^\^?(zip:|\/zip)\/+/, `/`); | ||
| } break; | ||
| } | ||
| } } |
Author
There was a problem hiding this comment.
ditto for this break after return.
Two braces on a line is a bit weird, but some style thing did it, so... 🤷♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/gh-actions/actions/runs/17195832258/attempts/1#summary-48777671013
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/gh-actions/actions/runs/17195832276/attempts/1#summary-48777670986