Improve query predicate error handling and add Rust integration tests#139
Open
DavidBakerEffendi wants to merge 3 commits intobonede:mainfrom
Open
Improve query predicate error handling and add Rust integration tests#139DavidBakerEffendi wants to merge 3 commits intobonede:mainfrom
DavidBakerEffendi wants to merge 3 commits intobonede:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of query predicate evaluation and expands test coverage for the Rust language bindings.
Key changes include:
TSQueryPredicateto throw anIllegalStateExceptionwhen source bytes are missing or invalid during text-based predicate evaluation (e.g.,#eq?,#match?). This replaces silent failures with explicit error reporting.TreeSitterRustTestthat verify complex query scenarios, including usage of#eq?and#not-eq?predicates on Rust attributes and macro derive names.TSQueryPredicateTestto verify that the library correctly handles and reports missing source data.These changes ensure that developers receive clear feedback when query execution environment is misconfigured.