Conversation
There was a problem hiding this comment.
Hey congratulations on your first PR! 🎉
For a working Semantic type there is one thing still missing though. The directory format has to be connected with the semantic type with plugin.register_semantic_type_to_format(). It also goes into plugin_setup with the other registrations.
To test the registration you can try to actually import an MGF file into an artifact with qiime tools import on the command line.
And also see some adjustments below:
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 99.65% 99.67% +0.01%
==========================================
Files 8 8
Lines 289 306 +17
Branches 38 39 +1
==========================================
+ Hits 288 305 +17
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VinzentRisch
left a comment
There was a problem hiding this comment.
Hey Looks great!!
Ready for merging!
This pull request closes issue #52 by adding the semantic type
MGF, the file formatMGFFileFormat, and the directory formatMGFDirFormat. Tests were added for both formats. The tests make use of the MGF parser in Pyteomics for validation.