Make nominal_length and nominal_sdev optional in experiments#26
Merged
misialq merged 6 commits intobokulich-lab:mainfrom Feb 26, 2026
Merged
Make nominal_length and nominal_sdev optional in experiments#26misialq merged 6 commits intobokulich-lab:mainfrom
misialq merged 6 commits intobokulich-lab:mainfrom
Conversation
added 5 commits
December 4, 2025 22:59
Updated mystmd applies CSS property limiting height of the image. Changing to center fixes the issue (since no CSS is applied on center)
misialq
requested changes
Feb 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 95.07% 95.13% +0.05%
==========================================
Files 27 27
Lines 1788 1808 +20
==========================================
+ Hits 1700 1720 +20
Misses 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6bf43cf to
e4387e4
Compare
misialq
approved these changes
Feb 26, 2026
Contributor
misialq
left a comment
There was a problem hiding this comment.
Hey @ZuzanaSebb, thanks for the updates - LGTM! 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @misialq,
I’ve removed
nominal_lengthandnominal_sdevfrom the mandatory experiment parameters, in line with the SRA XML schema.I updated
library.pyandtest_library.pyaccordingly.Regarding the provided experiment templates, I only modified
experiment_minimal.tsvto reflect these changes. The extended templates for single and paired reads remain unchanged. The minimal template uses paired reads by default, so users can follow it without specifyingnominal_lengthornominal_sdev.