Open
Conversation
Author
|
Hi @delucis, thanks for allowing the workflow to run. Unfortunately, none of the other versions were tested as it failed with 10.x. I upgraded react-scripts and removed node 10.x-16.x from the list of supported versions so I can eval if all works in the other versions listed - I added 18.x-24.x. Locally, I can only test node 18+. Maybe it's ok to remove all nodes < 18 ? |
Member
Member
|
Thanks — missed that! Hopefully @benbot can take a look 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Koa with Express
Checklist
main).Note
@types/koa__routerand@types/koa__corswithout causing havoc to npm, vscode or both.