Skip to content

Remove manual Headers iterator registration#5350

Open
itisrohit wants to merge 2 commits into
boa-dev:mainfrom
itisrohit:remove-manual-headers-iterator
Open

Remove manual Headers iterator registration#5350
itisrohit wants to merge 2 commits into
boa-dev:mainfrom
itisrohit:remove-manual-headers-iterator

Conversation

@itisrohit
Copy link
Copy Markdown

@itisrohit itisrohit commented Apr 25, 2026

This Pull Request is a follow-up to #4697, which closed #4688.

It changes the following:

  • Removes the remaining manual Headers.prototype[Symbol.iterator] registration from fetch runtime setup.
  • Uses the existing #[boa(symbol = "iterator")] class method as the single implementation path.
  • Updates the invalid receiver regression test to assert the TypeError contract instead of the old manual error message.

Tests run:

  • cargo fmt --check
  • git diff --check
  • cargo test -p boa_runtime headers
  • cargo test -p boa_engine recursion_in
  • cargo test

@itisrohit itisrohit requested a review from a team as a code owner April 25, 2026 10:36
@github-actions github-actions Bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. C-Runtime Issues and PRs related to Boa's runtime features and removed Waiting On Review Waiting on reviews from the maintainers labels Apr 25, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Apr 25, 2026
@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Apr 28, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,051 51,051 0
Ignored 1,482 1,482 0
Failed 592 592 0
Panics 0 0 0
Conformance 96.10% 96.10% 0.00%

Tested main commit: 8820b77750be087bff9448e6091baec9c8490f58
Tested PR commit: 9c5147906021a4f2b86d7c1207d7ccf9fb54f6b8
Compare commits: 8820b77...9c51479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support symbol-named methods in #[boa(class)] macro

1 participant