Add science-friendly Specs II#192
Merged
hyperrealist merged 11 commits intobluesky:mainfrom Jan 5, 2026
Merged
Conversation
coretl
reviewed
Dec 2, 2025
Contributor
coretl
left a comment
coretl
left a comment
There was a problem hiding this comment.
Looking good, just one question
hyperrealist
force-pushed
the
186-science-friendly-specs-ii
branch
from
7304d2b to
8c8f598
Compare
hyperrealist
commented
Dec 17, 2025
Contributor
Author
hyperrealist
left a comment
hyperrealist
left a comment
There was a problem hiding this comment.
README.md should be updated to reflect the (major) changes to Regions.
coretl
approved these changes
Dec 17, 2025
Contributor
coretl
left a comment
coretl
left a comment
There was a problem hiding this comment.
Minor docs tweaks, and the README needs updating as you said, apart from that looks good
coretl
reviewed
Dec 19, 2025
README.md
Outdated
|
|
||
| grid = Line(y, 2.1, 3.8, 12) * ~Line(x, 0.5, 1.5, 10) | ||
| spec = Fly(0.4 @ grid) & Circle(x, y, 1.0, 2.8, radius=0.5) | ||
| spec = Fly(Ellipse(x, 1, 3, 0.3, y, 2.8, snake=True)) |
Contributor
There was a problem hiding this comment.
I don't think this is quite the same? It has a different diameter at least. Also it's missing the 0.4 @
coretl
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #186
This PR addresses the remainder of issues in #186 not covered by #188
Circle(x_axis, x_centre, x_diameter, x_step, y_axis, y_centre, y_diameter=None, y_step=None, snake=True), which is filled with a possibly snaking gridPolygon(x_axis, y_axis, vertices, x_step, y_step=None, snake=True)which is filled with a possibly snaking grid. The maths from https://github.com/DiamondLightSource/scanpointgenerator/blob/master/scanpointgenerator/rois/polygonal_roi.py may be usefulMask, and the contents ofregions.py, and all code that uses them