fix(clean): use find to recursively remove dist and node_modules#4641
Open
nnabeyang wants to merge 2 commits intobluesky-social:mainfrom
Open
fix(clean): use find to recursively remove dist and node_modules#4641nnabeyang wants to merge 2 commits intobluesky-social:mainfrom
nnabeyang wants to merge 2 commits intobluesky-social:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the behavior of the
make cleantarget in the Makefile.Previously,
make cleanused:However:
distandnode_modulesdirectories across environments and shells (e.g., shells withoutglobstarenabled).node_packagesin this repository — the intended directory isnode_modules. A quickfind . -type d -name "node_packages"returned no results.As a result,
make cleandid not remove many of the expected build artifacts as intended.What Changed
findcommand that reliably locates all matching directories and deletes them:findthat the expected directories (distandnode_modules, including nested ones) are identified before deletion.Why This Matters
globstar) and may silently fail in some environments.node_packages), meaning some intended removals were never happening.distandnode_modulesdirs are cleaned.Verification
Before applying the change, the set of directories reported by:
matched expectations in workspace layouts with nested packages. After removal, those directories are indeed deleted.
Additionally, running:
returned no results, confirming that the previous pattern was referring to a non-existent directory.
Impact
This only affects the
make cleantarget: no other build behavior or code functionality is affected.