Skip to content

1.4: core: services: ping: ping360_ethernet_prober: Use REUSEADDR with 30303#3796

Merged
joaoantoniocardoso merged 1 commit intobluerobotics:1.4from
patrickelectric:reuse
Feb 12, 2026
Merged

1.4: core: services: ping: ping360_ethernet_prober: Use REUSEADDR with 30303#3796
joaoantoniocardoso merged 1 commit intobluerobotics:1.4from
patrickelectric:reuse

Conversation

@patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Feb 12, 2026

As requested

Summary by Sourcery

Bug Fixes:

  • Allow the Ping360 Ethernet prober to bind reliably to the broadcast port by enabling SO_REUSEADDR on its UDP socket.

Note

Low Risk
Single-socket option change limited to UDP discovery binding behavior; low likelihood of impacting other functionality beyond making binds more permissive.

Overview
Improves Ping360 Ethernet discovery reliability by enabling SO_REUSEADDR on the UDP socket before binding to port 30303, reducing failures when the port is already in use or recently closed.

Written by Cursor Bugbot for commit 80a5c64. This will update automatically on new commits. Configure here.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds SO_REUSEADDR to the UDP broadcast socket used in the Ping360 Ethernet prober to improve rebinding behavior on port 30303.

Sequence diagram for Ping360 Ethernet prober socket creation with SO_REUSEADDR

sequenceDiagram
    participant Ping360EthernetProber
    participant UDPSocket
    participant NetworkStack

    Ping360EthernetProber->>UDPSocket: socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP)
    Ping360EthernetProber->>UDPSocket: setsockopt(SOL_SOCKET, SO_BROADCAST, 1)
    Ping360EthernetProber->>UDPSocket: setsockopt(SOL_SOCKET, SO_REUSEADDR, 1)
    Ping360EthernetProber->>UDPSocket: settimeout(0.2)
    Ping360EthernetProber->>NetworkStack: sendto(broadcast, port_30303)
    NetworkStack-->>Ping360EthernetProber: recvfrom(responses)
Loading

File-Level Changes

Change Details Files
Enable address reuse on the UDP broadcast socket used during Ping360 Ethernet discovery.
  • Configure the probe’s UDP socket with SO_REUSEADDR in addition to SO_BROADCAST.
  • Keep existing timeout-based non-blocking receive behavior for discovery responses.
core/services/ping/ping360_ethernet_prober.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joaoantoniocardoso joaoantoniocardoso merged commit 1b5800d into bluerobotics:1.4 Feb 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants