1.4: core: services: ping: ping360_ethernet_prober: Use REUSEADDR with 30303#3796
Merged
joaoantoniocardoso merged 1 commit intobluerobotics:1.4from Feb 12, 2026
Merged
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds SO_REUSEADDR to the UDP broadcast socket used in the Ping360 Ethernet prober to improve rebinding behavior on port 30303. Sequence diagram for Ping360 Ethernet prober socket creation with SO_REUSEADDRsequenceDiagram
participant Ping360EthernetProber
participant UDPSocket
participant NetworkStack
Ping360EthernetProber->>UDPSocket: socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP)
Ping360EthernetProber->>UDPSocket: setsockopt(SOL_SOCKET, SO_BROADCAST, 1)
Ping360EthernetProber->>UDPSocket: setsockopt(SOL_SOCKET, SO_REUSEADDR, 1)
Ping360EthernetProber->>UDPSocket: settimeout(0.2)
Ping360EthernetProber->>NetworkStack: sendto(broadcast, port_30303)
NetworkStack-->>Ping360EthernetProber: recvfrom(responses)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Williangalvani
approved these changes
Feb 12, 2026
joaomariolago
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested
Summary by Sourcery
Bug Fixes:
Note
Low Risk
Single-socket option change limited to UDP discovery binding behavior; low likelihood of impacting other functionality beyond making binds more permissive.
Overview
Improves Ping360 Ethernet discovery reliability by enabling
SO_REUSEADDRon the UDP socket before binding to port30303, reducing failures when the port is already in use or recently closed.Written by Cursor Bugbot for commit 80a5c64. This will update automatically on new commits. Configure here.