Skip to content

Update base image#3768

Merged
patrickelectric merged 2 commits intobluerobotics:masterfrom
Williangalvani:base_update
Feb 12, 2026
Merged

Update base image#3768
patrickelectric merged 2 commits intobluerobotics:masterfrom
Williangalvani:base_update

Conversation

@Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Feb 5, 2026

This will help reduce the image size, as we are getting some packages updated when we re-run apt in core.

Master:
Screenshot 2026-02-12 at 17 00 23
This PR:
Screenshot 2026-02-12 at 16 59 51

Summary by Sourcery

Update the core image to use the newer blueos-base 0.2.3 and stop installing apt-based system tools in this layer, leaving only commented guidance for future package additions.

Enhancements:

  • Switch the core Dockerfile to build from bluerobotics/blueos-base:0.2.3 instead of 0.2.2.
  • Remove explicit apt-based system tool installation from the install-system-tools script, replacing it with commented placeholders to encourage inclusion in the base image.

Note

Medium Risk
Base image bump plus removal of installed system packages can change runtime behavior if the new base image doesn’t include all previously-installed dependencies.

Overview
Updates the core Docker build to use bluerobotics/blueos-base:0.2.4 instead of 0.2.2.

Removes the layer-time apt install of networking/system utilities from tools/install-system-tools.sh, leaving only commented guidance so these dependencies are expected to live in the base image.

Written by Cursor Bugbot for commit a019d41. This will update automatically on new commits. Configure here.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the core Docker image to use a newer base image and removes inline apt-based system package installation from the tools installer script, delegating package provisioning to the base image instead.

Flow diagram for updated install-system-tools script behavior

flowchart TD
    A["Start install-system-tools.sh"] --> B["Run parallel bootstrap scripts in /home/pi/tools"]
    B --> C{"Need additional system packages?"}
    C -->|No| D["Finish script (all system packages expected from base image)"]
    C -->|Yes| E["Manually run apt update and apt install for missing packages"]
    E --> F["Manually clean apt cache"]
    F --> D
Loading

File-Level Changes

Change Details Files
Update core Docker image to use the newer base image tag.
  • Change the base image tag from 0.2.2 to 0.2.3 in the multi-stage Dockerfile.
  • Ensure all subsequent stages inherit from the updated base stage without other behavioral changes.
core/Dockerfile
Stop installing system packages via the tools installer script and document that such packages should live in the base image.
  • Remove the apt update/install/clean commands that previously installed core networking/system packages at runtime.
  • Replace the removed commands with commented examples indicating where to add temporary apt installs if absolutely necessary, reinforcing the expectation they should move into the base image.
core/tools/install-system-tools.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Williangalvani Williangalvani marked this pull request as ready for review February 12, 2026 19:32
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of keeping the old apt commands commented out in install-system-tools.sh, consider either removing that block entirely or replacing it with a brief comment that points to where system packages are now managed (e.g., in the base image Dockerfile) to avoid confusion about dead code.
  • In the placeholder apt example, update && apt install is missing the apt before update; if you're keeping this as guidance, fix the example so it’s syntactically correct or make it explicitly non-runnable (e.g., mention it in prose rather than as a shell snippet).
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of keeping the old apt commands commented out in install-system-tools.sh, consider either removing that block entirely or replacing it with a brief comment that points to where system packages are now managed (e.g., in the base image Dockerfile) to avoid confusion about dead code.
- In the placeholder apt example, `update && apt install` is missing the `apt` before `update`; if you're keeping this as guidance, fix the example so it’s syntactically correct or make it explicitly non-runnable (e.g., mention it in prose rather than as a shell snippet).

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric merged commit 671d213 into bluerobotics:master Feb 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants