Replace custom implementation of min() and max() with std::min() and std::max()#188
Replace custom implementation of min() and max() with std::min() and std::max()#188MoonPadUSer wants to merge 1 commit intomasterfrom
Conversation
|
Why was this done? What is the reason to use min and max from std? |
|
yes, we wanna get rid of most custom written functions and types and switch to using their standard alternatives. that way we might be able to get rid of geom.h and tools.h some day |
|
Why do we not want to have geom.h and tools.h? |
|
Many of the things written in Also, most headers with these custom template classes are e.g., included more than once, among with other weirdnesses. I've never seen code have to include headers more than once without having header guards or |
|
@MoonPadUSer can you please rebase and squash both this and #189? |
179fd05 to
f8188c0
Compare
f8188c0 to
5a12104
Compare
This PR removes the custom implementation of
min()andmax()and replaces it withstd::min()andstd::max()