refactor: change open recipe in new window to pass recipe id#7392
Open
refactor: change open recipe in new window to pass recipe id#7392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
recipeIdinstead of encoded deeplinks when opening a new windowFor internal flows (open recipe in new window, save & run), we now pass just the recipe manifest id string through the IPC chain instead of encoding the full recipe into a deeplink. The server's existing recipe_id + load_recipe_by_id support handles the lookup.
Also refactored
createChatWindowfrom 6 positional optional params to an options object while I was in there.Before:
After:
Verified locally with recipes in new windows from the ui and from deeplinks.