Option to add changeable defaults in goose-releases#7373
Open
dorien-koelemeijer wants to merge 8 commits intomainfrom
Open
Option to add changeable defaults in goose-releases#7373dorien-koelemeijer wants to merge 8 commits intomainfrom
dorien-koelemeijer wants to merge 8 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for “changeable defaults” by introducing an optional defaults.yaml source that fills in missing config keys without overriding user-provided values, intended for goose-releases bundling.
Changes:
- Added
defaults_pathtoConfigand logic to load/mergedefaults.yamlwhen keys are missing. - Updated
get_paramdocumentation and adjustedall_valuesimplementation. - Added unit tests validating precedence: env > config > defaults, plus no-defaults behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add option to add changeable defaults in goose-releases. Currently, there's an option to add defaults in
init-configandbundles.py- the former will only add defaults when there is no config file, and the latter will override everything (even the user's config). This PR adds defaults that will be added if the user hasn't set certain variables in their local config file, but will never override the user's config.A PR will be made in goose-releases to add the defaults.yaml file and add some initial variables.
Type of Change
AI Assistance
Testing
Local/manual testing using
just run-ui