Skip to content

Comments

Option to add changeable defaults in goose-releases#7373

Open
dorien-koelemeijer wants to merge 8 commits intomainfrom
feat/load-defaults-from-goose-releases
Open

Option to add changeable defaults in goose-releases#7373
dorien-koelemeijer wants to merge 8 commits intomainfrom
feat/load-defaults-from-goose-releases

Conversation

@dorien-koelemeijer
Copy link
Collaborator

@dorien-koelemeijer dorien-koelemeijer commented Feb 20, 2026

Summary

Add option to add changeable defaults in goose-releases. Currently, there's an option to add defaults in init-config and bundles.py - the former will only add defaults when there is no config file, and the latter will override everything (even the user's config). This PR adds defaults that will be added if the user hasn't set certain variables in their local config file, but will never override the user's config.

A PR will be made in goose-releases to add the defaults.yaml file and add some initial variables.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Local/manual testing using just run-ui

Copilot AI review requested due to automatic review settings February 20, 2026 02:13
@dorien-koelemeijer dorien-koelemeijer marked this pull request as draft February 20, 2026 02:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for “changeable defaults” by introducing an optional defaults.yaml source that fills in missing config keys without overriding user-provided values, intended for goose-releases bundling.

Changes:

  • Added defaults_path to Config and logic to load/merge defaults.yaml when keys are missing.
  • Updated get_param documentation and adjusted all_values implementation.
  • Added unit tests validating precedence: env > config > defaults, plus no-defaults behavior.

@dorien-koelemeijer dorien-koelemeijer changed the title Add option to add changeable defaults in goose-releases Opption to add changeable defaults in goose-releases Feb 20, 2026
@dorien-koelemeijer dorien-koelemeijer changed the title Opption to add changeable defaults in goose-releases Option to add changeable defaults in goose-releases Feb 20, 2026
@dorien-koelemeijer dorien-koelemeijer marked this pull request as ready for review February 20, 2026 02:51
Copilot AI review requested due to automatic review settings February 20, 2026 02:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant